moby/brewlog
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Compare commits

base: moby:2e55c72522ba20524cdecbea34fd596881fd3859
Branches Tags
moby:dev
moby:feat/additional-invite-links
moby:prod
...
compare: moby:ebb05ed9c12395e06ad1f5539387c375f127257a
Branches Tags
moby:dev
moby:feat/additional-invite-links
moby:prod

3 commits
2e55c72522 ... ebb05ed9c1

Author SHA1 Message Date
Niels Göttsch
ebb05ed9c1 Merge branch 'feat/additional-invite-links' into dev
Some checks failed
Build & Publish / Check (push) Successful in 2m19s
Details
Build & Publish / Build & Publish (push) Failing after 3s
Details
2026-07-17 09:25:21 +02:00
Niels Göttsch
c108a39f2c fix(cli): use Duration::from_mins for token wait timeout 
Satisfies clippy::duration_suboptimal_units by expressing the 2-minute
browser-auth timeout with from_mins(2) instead of from_secs(120).
 2026-07-17 09:20:01 +02:00
Niels Göttsch
2312315f34 docs(readme): document prek install via uv in Development Setup 
prek is a standalone uv-installed binary, not provided by mise install.
When absent from PATH, `prek run -av` fails with a misleading
"failed to run cargo fmt -- --check" message. Add the `uv tool install
prek` step and a note clarifying the failure mode.
 2026-07-17 09:06:25 +02:00
2 changed files with 4 additions and 1 deletions
Show stats Expand all files Collapse all files

3
README.md
View file

@ -147,9 +147,12 @@ sudo apt install -y clang mold pkg-config libssl-dev \
mise trust mise trust
mise install # Install all dev tools mise install # Install all dev tools
mise run install-e2e # Install Chrome for Testing + ChromeDriver mise run install-e2e # Install Chrome for Testing + ChromeDriver
uv tool install prek # Install prek (git hook runner) as a standalone tool
prek install # Install git hooks prek install # Install git hooks
``` ```
> **Note:** `prek` is a standalone binary installed via [`uv`](https://docs.astral.sh/uv/) and must be on `PATH`. If it is missing, `prek run -av` cannot invoke `cargo fmt -- --check` and reports `failed to run cargo fmt -- --check` — this is the missing `prek`/toolchain, not a formatting error. Installing `prek` resolves it.
## Contributing ## Contributing
```bash ```bash

2
src/presentation/cli/tokens.rs
View file

@ -83,7 +83,7 @@ pub async fn create_token(client: &BrewlogClient, cmd: CreateTokenCommand) -> Re
result = rx => { result = rx => {
result.context("callback server closed without receiving a token")? result.context("callback server closed without receiving a token")?
} }
() = tokio::time::sleep(std::time::Duration::from_secs(120)) => { () = tokio::time::sleep(std::time::Duration::from_mins(2)) => {
return Err(anyhow!("timed out waiting for browser authentication (2 minutes)")); return Err(anyhow!("timed out waiting for browser authentication (2 minutes)"));
} }
}; };