From 2312315f342914f1fa3bd9c6e7d7a491d42fac60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20G=C3=B6ttsch?= Date: Fri, 17 Jul 2026 09:06:25 +0200 Subject: [PATCH 1/2] docs(readme): document prek install via uv in Development Setup prek is a standalone uv-installed binary, not provided by mise install. When absent from PATH, `prek run -av` fails with a misleading "failed to run cargo fmt -- --check" message. Add the `uv tool install prek` step and a note clarifying the failure mode. --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 88babdf..e6df071 100644 --- a/README.md +++ b/README.md @@ -147,9 +147,12 @@ sudo apt install -y clang mold pkg-config libssl-dev \ mise trust mise install # Install all dev tools mise run install-e2e # Install Chrome for Testing + ChromeDriver +uv tool install prek # Install prek (git hook runner) as a standalone tool prek install # Install git hooks ``` +> **Note:** `prek` is a standalone binary installed via [`uv`](https://docs.astral.sh/uv/) and must be on `PATH`. If it is missing, `prek run -av` cannot invoke `cargo fmt -- --check` and reports `failed to run cargo fmt -- --check` — this is the missing `prek`/toolchain, not a formatting error. Installing `prek` resolves it. + ## Contributing ```bash From c108a39f2c9968dd1d1e5b3ba20d584280950c4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20G=C3=B6ttsch?= Date: Fri, 17 Jul 2026 09:20:01 +0200 Subject: [PATCH 2/2] fix(cli): use Duration::from_mins for token wait timeout Satisfies clippy::duration_suboptimal_units by expressing the 2-minute browser-auth timeout with from_mins(2) instead of from_secs(120). --- src/presentation/cli/tokens.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/presentation/cli/tokens.rs b/src/presentation/cli/tokens.rs index ed38b30..008ce8e 100644 --- a/src/presentation/cli/tokens.rs +++ b/src/presentation/cli/tokens.rs @@ -83,7 +83,7 @@ pub async fn create_token(client: &BrewlogClient, cmd: CreateTokenCommand) -> Re result = rx => { result.context("callback server closed without receiving a token")? } - () = tokio::time::sleep(std::time::Duration::from_secs(120)) => { + () = tokio::time::sleep(std::time::Duration::from_mins(2)) => { return Err(anyhow!("timed out waiting for browser authentication (2 minutes)")); } };