moby/brewlog
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(brews): return reload response for brew-again from non-brew pages

Browse source 
The create_brew handler returned a #brew-list fragment for all Datastar
requests, but that element only exists on the brews data page. Requests
from the homepage or timeline now get a reload-script response instead,
fixing the PatchElementsNoTargetsFound error.
This commit is contained in:
Jon Seager 2026-02-06 17:52:28 +00:00
parent 835423f6ca
commit b4f9c02e5a
No known key found for this signature in database
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/application/routes/api/brews.rs
View file

@ -242,13 +242,18 @@ pub(crate) async fn create_brew(
info!(brew_id = %enriched.brew.id, "brew created"); info!(brew_id = %enriched.brew.id, "brew created");
if is_datastar_request(&headers) { if is_datastar_request(&headers) {
// Check if request came from timeline - return a script that redirects // If the request came from a page that has #brew-list, return the updated fragment.
let from_timeline = headers // Otherwise (homepage, timeline, etc.), trigger a page reload instead.
let from_brew_page = headers
.get("referer") .get("referer")
.and_then(|v| v.to_str().ok()) .and_then(|v| v.to_str().ok())
.is_some_and(|r| r.contains("/timeline")); .is_some_and(|r| r.contains("type=brews"));
if from_timeline { if from_brew_page {
render_brew_list_fragment(state, request, search, true)
.await
.map_err(ApiError::from)
} else {
use axum::http::header::HeaderValue; use axum::http::header::HeaderValue;
let mut response = let mut response =
axum::response::Html("<script>window.location.reload()</script>").into_response(); axum::response::Html("<script>window.location.reload()</script>").into_response();
@ -259,10 +264,6 @@ pub(crate) async fn create_brew(
.headers_mut() .headers_mut()
.insert("datastar-mode", HeaderValue::from_static("append")); .insert("datastar-mode", HeaderValue::from_static("append"));
Ok(response) Ok(response)
} else {
render_brew_list_fragment(state, request, search, true)
.await
.map_err(ApiError::from)
} }
} else if matches!(source, PayloadSource::Form) { } else if matches!(source, PayloadSource::Form) {
let target = let target =