From 807f438a82ac05153d7b22f9fc292dc1aa50886c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 24 Nov 2025 17:45:46 +0000 Subject: [PATCH] test: remove pagination and sorting tests Remove pagination and sorting tests from roasters and roasts test files as these will be addressed in a future pull request. Co-authored-by: jnsgruk <668505+jnsgruk@users.noreply.github.com> --- tests/server/roasters.rs | 78 ------------------------------------- tests/server/roasts.rs | 84 ---------------------------------------- 2 files changed, 162 deletions(-) diff --git a/tests/server/roasters.rs b/tests/server/roasters.rs index d415670..f886272 100644 --- a/tests/server/roasters.rs +++ b/tests/server/roasters.rs @@ -438,81 +438,3 @@ async fn creating_a_roaster_with_missing_required_fields_returns_a_400() { // Assert assert_eq!(response.status(), 400); } - -#[tokio::test] -async fn listing_roasters_with_pagination_returns_correct_page() { - // Arrange - let app = spawn_app().await; - let client = reqwest::Client::new(); - - // Create 5 roasters - for i in 1..=5 { - let roaster = NewRoaster { - name: format!("Roaster {}", i), - country: "UK".to_string(), - city: None, - homepage: None, - notes: None, - }; - client - .post(app.api_url("/roasters")) - .json(&roaster) - .send() - .await - .expect("Failed to create roaster"); - } - - // Act - Request page 1 with page_size=2 - let response = client - .get(app.api_url("/roasters?page=1&page_size=2")) - .send() - .await - .expect("Failed to execute request"); - - // Assert - assert_eq!(response.status(), 200); - let roasters: Vec = response.json().await.expect("Failed to parse response"); - // Note: The list endpoint returns all roasters, not paginated - assert_eq!(roasters.len(), 5); -} - -#[tokio::test] -async fn listing_roasters_returns_sorted_by_name_ascending() { - // Arrange - let app = spawn_app().await; - let client = reqwest::Client::new(); - - // Create roasters with different names - let names = vec!["Zebra Coffee", "Alpha Roasters", "Beta Beans"]; - for name in names { - let roaster = NewRoaster { - name: name.to_string(), - country: "UK".to_string(), - city: None, - homepage: None, - notes: None, - }; - client - .post(app.api_url("/roasters")) - .json(&roaster) - .send() - .await - .expect("Failed to create roaster"); - } - - // Act - The API always returns roasters sorted by name ascending - let response = client - .get(app.api_url("/roasters")) - .send() - .await - .expect("Failed to execute request"); - - // Assert - assert_eq!(response.status(), 200); - let roasters: Vec = response.json().await.expect("Failed to parse response"); - assert_eq!(roasters.len(), 3); - // Verify they're sorted by name ascending (API default behavior) - assert_eq!(roasters[0].name, "Alpha Roasters"); - assert_eq!(roasters[1].name, "Beta Beans"); - assert_eq!(roasters[2].name, "Zebra Coffee"); -} diff --git a/tests/server/roasts.rs b/tests/server/roasts.rs index 582e5e1..937bf86 100644 --- a/tests/server/roasts.rs +++ b/tests/server/roasts.rs @@ -509,87 +509,3 @@ async fn creating_a_roast_with_malformed_json_returns_a_400() { // Assert assert_eq!(response.status(), 400); } - -#[tokio::test] -async fn listing_roasts_with_pagination_returns_correct_page() { - // Arrange - let app = spawn_app().await; - let roaster_id = create_test_roaster(&app).await; - let client = reqwest::Client::new(); - - // Create 5 roasts - for i in 1..=5 { - let roast = NewRoast { - roaster_id: roaster_id.clone(), - name: format!("Roast {}", i), - origin: "Brazil".to_string(), - region: "Santos".to_string(), - producer: "Farm".to_string(), - tasting_notes: vec!["Chocolate".to_string()], - process: "Natural".to_string(), - }; - client - .post(app.api_url("/roasts")) - .json(&roast) - .send() - .await - .expect("Failed to create roast"); - } - - // Act - Request page 1 with page_size=2 - let response = client - .get(app.api_url("/roasts?page=1&page_size=2")) - .send() - .await - .expect("Failed to execute request"); - - // Assert - assert_eq!(response.status(), 200); - let roasts: Vec = response.json().await.expect("Failed to parse response"); - // Note: The list endpoint returns all roasts, not paginated - assert_eq!(roasts.len(), 5); -} - -#[tokio::test] -async fn listing_roasts_returns_sorted_by_created_at_descending() { - // Arrange - let app = spawn_app().await; - let roaster_id = create_test_roaster(&app).await; - let client = reqwest::Client::new(); - - // Create roasts with different names (they'll be sorted by created_at descending by default) - let names = vec!["First Roast", "Second Roast", "Third Roast"]; - for name in names { - let roast = NewRoast { - roaster_id: roaster_id.clone(), - name: name.to_string(), - origin: "Brazil".to_string(), - region: "Santos".to_string(), - producer: "Farm".to_string(), - tasting_notes: vec!["Chocolate".to_string()], - process: "Natural".to_string(), - }; - client - .post(app.api_url("/roasts")) - .json(&roast) - .send() - .await - .expect("Failed to create roast"); - } - - // Act - The API returns roasts sorted by created_at descending by default - let response = client - .get(app.api_url("/roasts")) - .send() - .await - .expect("Failed to execute request"); - - // Assert - assert_eq!(response.status(), 200); - let roasts: Vec = response.json().await.expect("Failed to parse response"); - assert_eq!(roasts.len(), 3); - // Verify they're sorted by created_at descending (newest first) - assert_eq!(roasts[0].roast.name, "Third Roast"); - assert_eq!(roasts[1].roast.name, "Second Roast"); - assert_eq!(roasts[2].roast.name, "First Roast"); -}