moby/brewlog
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(bags): align order_clause with other repositories

Browse source 
- Use method access (sort_key(), sort_direction()) instead of field
  access for consistency with roasters.rs and roasts.rs
- Add secondary sort clauses (e.g., created_at DESC) as tiebreakers
  to ensure deterministic pagination results
This commit is contained in:
Jon Seager 2026-02-02 14:28:45 +00:00
parent c941cd83fb
commit 2e4c8722ca
No known key found for this signature in database
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/infrastructure/repositories/bags.rs
View file

@ -31,20 +31,18 @@ impl SqlBagRepository {
}
fn order_clause(request: &ListRequest<BagSortKey>) -> String {
let sort_column = match request.sort_key {
BagSortKey::RoastDate => "b.roast_date",
BagSortKey::CreatedAt => "b.created_at",
BagSortKey::Roaster => "rr.name",
BagSortKey::Roast => "r.name",
BagSortKey::FinishedAt => "b.finished_at",
};
let direction = match request.sort_direction {
let dir_sql = match request.sort_direction() {
SortDirection::Asc => "ASC",
SortDirection::Desc => "DESC",
};
format!("{} {}", sort_column, direction)
match request.sort_key() {
BagSortKey::RoastDate => format!("b.roast_date {dir_sql}, b.created_at DESC"),
BagSortKey::CreatedAt => format!("b.created_at {dir_sql}, b.id DESC"),
BagSortKey::Roaster => format!("LOWER(rr.name) {dir_sql}, b.created_at DESC"),
BagSortKey::Roast => format!("LOWER(r.name) {dir_sql}, b.created_at DESC"),
BagSortKey::FinishedAt => format!("b.finished_at {dir_sql}, b.created_at DESC"),
}
}
fn to_domain(record: BagRecord) -> Bag {